Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add enabled flag to each component in Helm chart #372

Merged
merged 3 commits into from
May 12, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 12, 2020

Description:

I've added enabled flag to each component in Helm chart.
And also a values yaml for deploying standalone agent NGT pods is added.

Related Issue:

Nothing.

How Has This Been Tested?:

local machine.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 12, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ✨ Add enabled flag to each component

     🍱 Add agent standalone values

     📝 Add description about ingress

Powered by Pull Assistant. Last update 436215f ... 0b5f5fc. Read the comment docs.

@rinx rinx marked this pull request as ready for review May 12, 2020 05:22
kpango
kpango previously approved these changes May 12, 2020
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rinx added 3 commits May 12, 2020 18:43
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the feature/helm/add-enabled-flag-to-each-component branch from c16dc15 to 0b5f5fc Compare May 12, 2020 09:43
@rinx
Copy link
Contributor Author

rinx commented May 12, 2020

I've just resolved conflicts.

@kpango kpango merged commit d74cb61 into master May 12, 2020
@kpango kpango deleted the feature/helm/add-enabled-flag-to-each-component branch May 12, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants